Evaluate request body strictly to fix #34 #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, this is not a solution that I'd be willing to merge in, it has a major and negative impact on many common applications. We can discuss in the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way this library currently constructs the
requestBodyto pass tohttp-clientis triggering #34 . I'm not sure why, but I'm hoping it will be obvious to someone familiar withhttp-client.This change fixes the problem, although it has to evaluate the entire body to do so. A better solution wouldn't require us to give up on
HC.RequestBodyStreamandHC.RequestBodyStreamChunked, so hopefully this is a sufficient clue about how to fix it properly.(I tried replacing
WAI.requestBodywithWAI.getRequestBodyChunkin the original code, since the former is deprecated, but that didn't change anything.)