Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken on GHC 9.4 / text 2.0 #55

Closed
jberryman opened this issue Apr 27, 2023 · 1 comment
Closed

Broken on GHC 9.4 / text 2.0 #55

jberryman opened this issue Apr 27, 2023 · 1 comment

Comments

@jberryman
Copy link
Contributor

jberryman commented Apr 27, 2023

On current Master branch:

$ ODBC_TEST_CONNECTION_STRING='DRIVER={ODBC Driver 17 for SQL Server};SERVER=127.0.0.1;Uid=SA;Pwd=Passw0rd;Encrypt=no' cabal test -w ghc-9.2.7
…
1 of 1 test suites (1 of 1 test cases) passed.

however:

ODBC_TEST_CONNECTION_STRING='DRIVER={ODBC Driver 17 for SQL Server};SERVER=127.0.0.1;Uid=SA;Pwd=Passw0rd;Encrypt=no' cabal test -w ghc-9.4.5
…snip…
 test/Main.hs:103:3: 
  1) Database.ODBC.Internal, Regression tests, Internal.exec can return SQL_NO_DATA
       uncaught exception: ODBCException
       UnsuccessfulReturnCode "odbc_SQLExecDirectW" (-1) "[Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Incorrect syntax near '\8262'." (Just "42000")

  To rerun use: --match "/Database.ODBC.Internal/Regression tests/Internal.exec can return SQL_NO_DATA/"

  test/Main.hs:110:3: 
  2) Database.ODBC.Internal, Regression tests, Internal.exec multiple statements (https://github.com/fpco/odbc/issues/9)
       uncaught exception: ODBCException
       UnsuccessfulReturnCode "odbc_SQLExecDirectW" (-1) "[Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Incorrect syntax near '\8251'." (Just "42000")

  To rerun use: --match "/Database.ODBC.Internal/Regression tests/Internal.exec multiple statements (https://github.com/fpco/odbc/issues/9)/"
…snip…
100 examples, 47 failures, 44 pending

there certainly needs to be a special case for text v2 here, but simply removing the * 2 did not fix the bug

haskell/text#365

@jberryman
Copy link
Contributor Author

fix here though it hasn't been reviewed yet: https://github.com/hasura/odbc/tree/9.4-take2

@psibi psibi closed this as completed in cf169fa Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant