Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text 1.2.3.0 #3147

Closed
1 of 4 tasks
snoyberg opened this issue Dec 28, 2017 · 7 comments
Closed
1 of 4 tasks

text 1.2.3.0 #3147

snoyberg opened this issue Dec 28, 2017 · 7 comments

Comments

@snoyberg
Copy link
Contributor

snoyberg commented Dec 28, 2017

text-1.2.3.0 is out of bounds for:

snoyberg added a commit that referenced this issue Dec 28, 2017
@laserpants
Copy link
Contributor

Does this work? 🤔

@@ -24,7 +24,7 @@ library
                      , base-unicode-symbols ==0.2.2.4
                      , data-default ==0.7.1.1
                      , lens ==4.15.4
-                     , text ==1.2.2.2
+                     , text >=1.2.2.2
                      , text-metrics ==0.3.0
                      , unordered-containers ==0.2.8.0
                      , vector ==0.12.0.1

@snoyberg
Copy link
Contributor Author

I haven't tested that it compiles, but generally those style of version bounds (ranges) are better than pinning a specific version.

@laserpants
Copy link
Contributor

Ok, thanks. To be honest, I don't really know how to reason about this (version bounds), but I have set up Travis CI and the build completes there without any issues.

@laserpants
Copy link
Contributor

I pushed this as ver. 0.1.0.3 to Hackage.

@DanBurton
Copy link
Contributor

To be honest, I don't really know how to reason about this (version bounds)

@laserpants Opinions vary on this, but here is some stuff you can read on Hackage's Package Versioning Policy (PVP):
https://pvp.haskell.org/#dependencies-in-cabal

@DanBurton
Copy link
Contributor

New entry:

Please note that we will be moving to text-1.2.3.0 for nightlies soon, and incompatible packages will be dropped from the build plan until compatibility is restored.

phadej added a commit to phadej/servant that referenced this issue Jan 25, 2018
- `text` is already 1.2.3.0 as commercialhaskell/stackage#3147
  is resolved AFAICS

- `http-types` bound is surprisingly low due:
  commercialhaskell/stackage#2976
phadej added a commit to phadej/servant that referenced this issue Jan 25, 2018
- `text` is already 1.2.3.0 as commercialhaskell/stackage#3147
  is resolved AFAICS

- `http-types` bound is surprisingly low due:
  commercialhaskell/stackage#2976
phadej added a commit to phadej/servant that referenced this issue Jan 25, 2018
- `text` is already 1.2.3.0 as commercialhaskell/stackage#3147
  is resolved AFAICS

- `http-types` bound is surprisingly low due:
  commercialhaskell/stackage#2976
phadej added a commit to phadej/servant that referenced this issue Jan 25, 2018
- `text` is already 1.2.3.0 as commercialhaskell/stackage#3147
  is resolved AFAICS

- `http-types` bound is surprisingly low due:
  commercialhaskell/stackage#2976
phadej added a commit to phadej/servant that referenced this issue Jan 25, 2018
- `text` is already 1.2.3.0 as commercialhaskell/stackage#3147
  is resolved AFAICS

- `http-types` bound is surprisingly low due:
  commercialhaskell/stackage#2976
@DanBurton
Copy link
Contributor

The following were removed from the nighty build plan in order to accommodate text-1.2.3.0:

@DanBurton DanBurton mentioned this issue Jan 26, 2018
1 task
ollef pushed a commit to folq/servant-foreign-bidirectional that referenced this issue Aug 23, 2019
- `text` is already 1.2.3.0 as commercialhaskell/stackage#3147
  is resolved AFAICS

- `http-types` bound is surprisingly low due:
  commercialhaskell/stackage#2976
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants