Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try enabling darcs 2.12.1 #1848

Merged
merged 1 commit into from Sep 7, 2016
Merged

Conversation

simonmichael
Copy link
Contributor

No description provided.

@juhp juhp merged commit e137aee into commercialhaskell:master Sep 7, 2016
@juhp
Copy link
Contributor

juhp commented Sep 7, 2016

Thanks

@simonmichael simonmichael deleted the patch-8 branch September 7, 2016 01:14
@juhp
Copy link
Contributor

juhp commented Sep 7, 2016

Unfortunately the testsuite is failing... see http://bugs.darcs.net/issue2507

@juhp
Copy link
Contributor

juhp commented Sep 7, 2016

So I disabled darcs again for now.

(Despite failing the testsuite also seems to timeout sometimes in the stackage build.)

@simonmichael
Copy link
Contributor Author

I thought some of these problem tests were disabled in the release 2.12 branch, but I guess not.

Last time this happened, I believe the darcs tests were disabled in build-constraints.yaml - could we do that for now ?

@RyanGlScott
Copy link
Contributor

darcs-2.12.2 is on Hackage, which claims to fix the test suite.

@simonmichael
Copy link
Contributor Author

Nice, trying again.

@simonmichael simonmichael mentioned this pull request Sep 7, 2016
@simonmichael
Copy link
Contributor Author

Incidentally @juhp, shouldn't the Travis job have notified me of the problem with tests ? What did you do differently from me, to see it ?

@juhp
Copy link
Contributor

juhp commented Sep 8, 2016

@simonmichael unfortunately not - the travis job only does dependency version consistency checking.
For stackage snapshots (nightly and lts) we actually build packages, but we don't have a story yet for building packages before adding them.

In retrospect i was pondering just to let the darcs fail in stackage since darcs has been in Stackage before, but let's see if the new release is okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants