Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support text-2.0 #65

Merged
merged 1 commit into from Dec 5, 2021
Merged

Support text-2.0 #65

merged 1 commit into from Dec 5, 2021

Conversation

Bodigrim
Copy link
Contributor

@Bodigrim Bodigrim commented Dec 2, 2021

Closes #63. Tested with

resolver: lts-18.18

extra-deps:
  - hashable-1.4.0.1
  - github: haskell/text
    commit: aee3efe6819fc524bf16daae2936a9bae79748f7

UTF8 decoding in text-2.0 is quite involved and it does not seem right to copy the implementation in full (e. g., it involves 500 Kb of C++ library), so I cheated a bit. I hope it is acceptable, but open to discuss alternatives.

snoyberg
snoyberg approved these changes Dec 5, 2021
View reviewed changes
Copy link
Member

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snoyberg snoyberg merged commit 756b5c7 into fpco:master Dec 5, 2021
snoyberg added a commit that referenced this pull request Dec 5, 2021
@snoyberg
Version bump for #65
f363d24
@yoricksijsling yoricksijsling mentioned this pull request Jul 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snoyberg snoyberg snoyberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compatibility with text-2.0
2 participants
@Bodigrim @snoyberg