Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mypy #10

Closed
fpgmaas opened this issue Sep 2, 2022 · 1 comment · Fixed by #135
Closed

Add mypy #10

fpgmaas opened this issue Sep 2, 2022 · 1 comment · Fixed by #135
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@fpgmaas
Copy link
Owner

fpgmaas commented Sep 2, 2022

Mypy turned off for initial development. We should add it again.
@fpgmaas fpgmaas added the enhancement New feature or request label Sep 2, 2022
@fpgmaas fpgmaas mentioned this issue Sep 3, 2022
Closed
@fpgmaas
Copy link
Owner Author

fpgmaas commented Sep 4, 2022

Main issue is currently in passing the configuration values to the Core object:

deptry/cli.py:67: error: Argument "ignore_dependencies" to "Core" has incompatible type "Union[bool, List[str], None]"; expected "List[str]"  [arg-type]
deptry/cli.py:68: error: Argument "ignore_directories" to "Core" has incompatible type "Union[bool, List[str], None]"; expected "List[str]"  [arg-type]
deptry/cli.py:69: error: Argument "ignore_notebooks" to "Core" has incompatible type "Union[bool, List[str], None]"; expected "bool"  [arg-type]

@fpgmaas fpgmaas added the good first issue Good for newcomers label Sep 4, 2022
@mkniewallner mkniewallner mentioned this issue Sep 27, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve typing to make mypy pass and activate mypy on CI mkniewallner/deptry
1 participant
@fpgmaas