Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise the way that configuration is handled. #4

Closed
fpgmaas opened this issue Sep 2, 2022 · 2 comments · Fixed by #20
Closed

Revise the way that configuration is handled. #4

fpgmaas opened this issue Sep 2, 2022 · 2 comments · Fixed by #20
Labels
enhancement New feature or request

Comments

@fpgmaas
Copy link
Owner

fpgmaas commented Sep 2, 2022

Priority should be as follows:

  • default
  • pyproject.toml
  • cli arguments

The way this is currently handled with the creation of a cli_arguments dictionary in cli.py is not very nice, there is room for improvement there.

@fpgmaas fpgmaas added the enhancement New feature or request label Sep 2, 2022
@fpgmaas
Copy link
Owner Author

fpgmaas commented Sep 3, 2022

This is currently blocking #10. bool and List[str] arguments are both added as values to the same dict with cli arguments, so from that point on mypy can not distinguish between these anymore, and the Core class does not know which arguments are booleans, and which ones are List[str].

@fpgmaas
Copy link
Owner Author

fpgmaas commented Sep 4, 2022

Cleand up the config handling and moved some of the config handling out of cli.py to config.py. However, this still does not solve mypy's type checking.

@fpgmaas fpgmaas linked a pull request Sep 4, 2022 that will close this issue
@fpgmaas fpgmaas closed this as completed Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant