Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve violation finder #655

Merged

Conversation

mkniewallner
Copy link
Collaborator

@mkniewallner mkniewallner commented Apr 1, 2024

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

This PR reduces a bit code duplication and moves the violations finder logic out of Core god class.

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 76.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 92.4%. Comparing base (a40f47b) to head (c2cd410).

Files Patch % Lines
python/deptry/violations/finder.py 61.5% 5 Missing ⚠️
python/deptry/core.py 50.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #655     +/-   ##
=======================================
+ Coverage   91.8%   92.4%   +0.5%     
=======================================
  Files         34      35      +1     
  Lines        947     950      +3     
  Branches     197     194      -3     
=======================================
+ Hits         870     878      +8     
+ Misses        60      55      -5     
  Partials      17      17             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkniewallner mkniewallner marked this pull request as ready for review April 1, 2024 20:57
@mkniewallner mkniewallner force-pushed the refactor/improve-violation-finder branch from 1706cb5 to c2cd410 Compare April 2, 2024 11:31
@fpgmaas fpgmaas merged commit af87217 into fpgmaas:main Apr 2, 2024
28 of 29 checks passed
@mkniewallner mkniewallner deleted the refactor/improve-violation-finder branch April 7, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants