Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ruff): enable flake8-no-pep420 #659

Merged

Conversation

mkniewallner
Copy link
Collaborator

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

Enable https://docs.astral.sh/ruff/rules/implicit-namespace-package/, as this is known to cause some issues with some tools. The original repository provides a bit more information about the rationale.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.4%. Comparing base (af87217) to head (c41b741).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #659   +/-   ##
=====================================
  Coverage   92.4%   92.4%           
=====================================
  Files         35      35           
  Lines        950     950           
  Branches     194     194           
=====================================
  Hits         878     878           
  Misses        55      55           
  Partials      17      17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkniewallner mkniewallner marked this pull request as ready for review April 2, 2024 22:50
@mkniewallner mkniewallner merged commit 7e5b4e2 into fpgmaas:main Apr 3, 2024
29 checks passed
@mkniewallner mkniewallner deleted the chore/enable-flake8-no-pep420 branch April 3, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants