Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pre-commit): check lock files #697

Merged
merged 3 commits into from
May 1, 2024

Conversation

mkniewallner
Copy link
Collaborator

@mkniewallner mkniewallner commented May 1, 2024

PR Checklist

  • A description of the changes is added to the description of this PR.
  • If there is a related issue, make sure it is linked to this PR.
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added or modified a feature, documentation in docs is updated

Description of changes

I feel dumb for not thinking about this, but the implementation in #692 does not work as expected, as this will not refresh Cargo.lock, as can be seen in #694 (since Renovate doesn't handle the dependency as a Cargo one). So this PR removes this, but also adds lock files check, which would have prevented the PR updating Ruff from getting merged, as the lock file was inconsistent.

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.4%. Comparing base (c55111b) to head (4e56a8d).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #697   +/-   ##
=====================================
  Coverage   92.4%   92.4%           
=====================================
  Files         35      35           
  Lines        958     958           
  Branches     176     176           
=====================================
  Hits         886     886           
  Misses        55      55           
  Partials      17      17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkniewallner mkniewallner marked this pull request as ready for review May 1, 2024 13:07
@mkniewallner mkniewallner requested a review from fpgmaas May 1, 2024 13:07
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@mkniewallner mkniewallner enabled auto-merge (squash) May 1, 2024 17:41
@mkniewallner mkniewallner merged commit e4d74bd into fpgmaas:main May 1, 2024
21 checks passed
@mkniewallner mkniewallner deleted the chore/check-lock-files branch May 2, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants