Skip to content
This repository has been archived by the owner on Sep 2, 2023. It is now read-only.

Commit

Permalink
cope with pandas not using semantic versioning: add upper version con…
Browse files Browse the repository at this point in the history
  • Loading branch information
fphammerle committed Dec 31, 2020
1 parent 097062f commit 3e21ed9
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,12 @@
packages=setuptools.find_packages(),
install_requires=[
"numpy<2",
# hoping pandas maintainers use semantic versioning
# pandas v1.2.0 made `get_filepath_or_buffer` private without releasing major version.
# semver?!? not even mentioned in changelog
# https://pandas.pydata.org/pandas-docs/stable/whatsnew/v1.2.0.html
# https://github.com/pandas-dev/pandas/commit/6d1541e1782a7b94797d5432922e64a97934cfa4#diff-934d8564d648e7521db673c6399dcac98e45adfd5230ba47d3aabfcc21979febL247
# TODO verify lower version constraint
"pandas>=0.21,<2",
"pandas>=0.21,<1.2",
],
setup_requires=["setuptools_scm"],
tests_require=["pytest<5"],
Expand Down

0 comments on commit 3e21ed9

Please sign in to comment.