Skip to content
This repository has been archived by the owner on Sep 2, 2023. It is now read-only.

Commit

Permalink
env: downgrade importlib-metadata to fix pipeline on python3.5
Browse files Browse the repository at this point in the history
  • Loading branch information
fphammerle committed Dec 26, 2020
1 parent aa60ecb commit 3e663f9
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 12 deletions.
6 changes: 0 additions & 6 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,6 @@ matrix:
install:
- pip install pipenv
- pipenv sync --dev
# ModuleNotFoundError: No module named 'importlib_metadata'
# https://github.com/WanzenBug/pylint-import-requirements/issues/17
- if python3 -c 'import sys; sys.exit(sys.version_info < (3, 8))'; then
pipenv graph;
pipenv install --dev importlib-metadata;
fi
- if [ ! -z "$PANDAS_VERSION" ]; then
pipenv install --selective-upgrade "pandas==$PANDAS_VERSION";
fi
Expand Down
7 changes: 5 additions & 2 deletions Pipfile
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,11 @@ pylint-import-requirements = "*"
pytest-cov = ">=2"

# python3.5 compatibility
# https://github.com/python/importlib_metadata/commit/107f9029fd5807c6579b881db19e11a0488f0675
importlib-metadata = "<3"
# <2 for:
# > pkg_resources.VersionConflict: (importlib-metadata 2.1.1 (/home/travis/virtualenv/python3.5.10/lib/python3.5/site-packages),
# > Requirement.parse('importlib-metadata<2,>=0.12; python_version < "3.8"'))
# <3 for "python_requires" https://github.com/python/importlib_metadata/commit/107f9029fd5807c6579b881db19e11a0488f0675
importlib-metadata = "<2,<3"
isort = "<5"
# workaround https://github.com/pytest-dev/pytest/issues/3953
pathlib2 = {version = "*", markers="python_version < '3.6'"}
Expand Down
8 changes: 4 additions & 4 deletions Pipfile.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 3e663f9

Please sign in to comment.