Skip to content

Commit

Permalink
pylint: enable various optional checks
Browse files Browse the repository at this point in the history
  • Loading branch information
fphammerle committed Jun 4, 2022
1 parent cde354f commit 3ddcbbd
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 4 deletions.
27 changes: 25 additions & 2 deletions .pylintrc
Original file line number Diff line number Diff line change
@@ -1,4 +1,27 @@
[MESSAGE CONTROL]
[MASTER]

disable=missing-function-docstring,
load-plugins=pylint.extensions.bad_builtin,
pylint.extensions.broad_try_clause,
pylint.extensions.check_elif,
pylint.extensions.comparison_placement,
pylint.extensions.confusing_elif,
pylint.extensions.consider_ternary_expression,
pylint.extensions.emptystring,
pylint.extensions.eq_without_hash,
pylint.extensions.for_any_all,
pylint.extensions.mccabe,
pylint.extensions.no_self_use,
pylint.extensions.overlapping_exceptions,
pylint.extensions.private_import,
pylint.extensions.redefined_loop_name,
pylint.extensions.redefined_variable_type,
pylint.extensions.set_membership,
pylint.extensions.typing,
pylint.extensions.while_used

[MESSAGES CONTROL]

disable=consider-alternative-union-syntax, # requires python>=3.10
deprecated-typing-alias, # requires python>=3.9, e.g. for dict[...]
missing-function-docstring,
missing-module-docstring
2 changes: 1 addition & 1 deletion ical2vdir/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def _write_event(event: icalendar.cal.Event, path: pathlib.Path) -> None:
temp_fd, temp_path = tempfile.mkstemp(
prefix="ical2vdir-", suffix=_VDIR_EVENT_FILE_EXTENSION
)
try:
try: # pylint: disable=too-many-try-statements
# > Content lines are delimited by a line break,
# > which is a CRLF sequence [...]
# https://tools.ietf.org/html/rfc5545#section-3.1
Expand Down
2 changes: 1 addition & 1 deletion tests/cli_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
import subprocess
import unittest.mock

import _pytest.logging
import _pytest.logging # pylint: disable=import-private-name; tests
import icalendar

import ical2vdir
Expand Down

0 comments on commit 3ddcbbd

Please sign in to comment.