Skip to content

Commit

Permalink
drop compatibility with python3.7 (reached end of life on 2023-06-27)
Browse files Browse the repository at this point in the history
  • Loading branch information
fphammerle committed Aug 12, 2023
1 parent f74b7df commit 6b1b7e1
Show file tree
Hide file tree
Showing 5 changed files with 97 additions and 132 deletions.
13 changes: 10 additions & 3 deletions .github/workflows/python.yml
Expand Up @@ -23,7 +23,7 @@ jobs:
- uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
- run: pip install --upgrade pipenv==2020.8.13
- run: pip install --upgrade pipenv==2023.6.18
- run: pipenv install --python "$PYTHON_VERSION" --deploy --dev
env:
PYTHON_VERSION: ${{ matrix.python-version }}
Expand All @@ -34,7 +34,6 @@ jobs:
strategy:
matrix:
python-version:
- '3.7'
- '3.8'
- '3.9'
- '3.10'
Expand All @@ -46,7 +45,15 @@ jobs:
- uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
- run: pip install --upgrade pipenv==2020.8.13
# with pipenv v2023.6.26:
# > $ pipenv run pytest --cov="$(cat *.egg-info/top_level.txt)"
# . --cov-report=term-missing --cov-fail-under=100
# > cat: '*.egg-info/top_level.txt': No such file or directory
# > [...]
# > [...]/coverage/inorout.py:507: CoverageWarning:
# . Module was never imported. (module-not-imported)
- run: pip install --upgrade pipenv==2023.6.18
# by default pipenv picks the latest version in PATH
- run: pipenv install --python "$PYTHON_VERSION" --deploy --dev
env:
PYTHON_VERSION: ${{ matrix.python-version }}
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
Expand Up @@ -10,7 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
(by manually setting build argument `SETUPTOOLS_SCM_PRETEND_VERSION`)

### Removed
- compatibility with `python3.5` & `python3.6`
- compatibility with `python3.5`, `python3.6` & `python3.7`

## [0.1.1] - 2021-02-14
### Fixed
Expand Down
8 changes: 2 additions & 6 deletions Pipfile
Expand Up @@ -14,16 +14,11 @@ pylint-import-requirements = "*"
pytest = "*"
pytest-cov = "*"

# python3.7 compatibility
# https://github.com/PyCQA/isort/commit/47cedf3583f338e8ce9c906fc95c9fee6c57404d
isort = "<5.12"
# python3.10 compatibility
# > File "[...]/lib/python3.10/site-packages/mypy/main.py", line 11, in <module>
# > from typing_extensions import Final, NoReturn
# > ModuleNotFoundError: No module named 'typing_extensions'
typing_extensions = {version = "*", markers = ""}
# mypy on python<3.8
typed-ast = {markers = "python_version < '3.8'"}
typing-extensions = {markers = ""}
# python<=3.8 compatibility
# > [...]/python3.8/site-packages/telegram/ext/jobqueue.py:27: in <module>
# > from apscheduler.schedulers.background import BackgroundScheduler
Expand All @@ -36,6 +31,7 @@ typed-ast = {markers = "python_version < '3.8'"}
# > E ModuleNotFoundError: No module named 'backports'
# > Error: Process completed with exit code 4.
"backports.zoneinfo" = {version = "*", markers = "python_version <= '3.8'"}
# python<3.11 compatibility
# > File "[...]/lib/python3.10/site-packages/_pytest/_code/code.py", line 60, in <module>
# > from exceptiongroup import BaseExceptionGroup
# > ModuleNotFoundError: No module named 'exceptiongroup'
Expand Down

0 comments on commit 6b1b7e1

Please sign in to comment.