Fix css loading and add logging #140
Conversation
| reset_cache! if @cache.nil? | ||
| @cache | ||
| end | ||
|
|
There was a problem hiding this comment.
Cache was spread through two different places, the old CacheLoader and this module, which kinda breaks encapsulation. Now cache is fully implemented here and a little bit more robust.
|
Changes Unknown when pulling 50bc56f on doximity:fix_loading_and_add_logging into * on fphilipe:master*. |
|
Changes Unknown when pulling 11c9769 on doximity:fix_loading_and_add_logging into * on fphilipe:master*. |
1 similar comment
|
Changes Unknown when pulling 11c9769 on doximity:fix_loading_and_add_logging into * on fphilipe:master*. |
|
Looks good, please rebase. 👍 |
|
Does this fix the timeout problems in #108? If so, I'd love to see this merged! |
| CSSLoaders::FileSystemLoader, | ||
| CSSLoaders::AssetPipelineLoader, | ||
| CSSLoaders::NetworkLoader | ||
| CSSLoaders::NetworkLoader, |
|
I did some refactoring of how the cache works and thus some of this no longer applies. Closing, but feel free to reopen a new PR (ideally doing one change at a time). |
This pull requests introduce a couple of small fixes around css loading to make sure that they are only loaded using one strategy. It also adds a debug logging to show which strategy was used.
See notes on the code.