Fix TypeError on production environment with non existing asset #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbonislawski
added a commit
to spark-solutions/spree
that referenced
this pull request
Nov 27, 2017
if asset pipeline tries to fetch asset from url on production, it raises TypeError because of problem with sprockets issue in premailer-rails: fphilipe/premailer-rails#208
bbonislawski
force-pushed
the
fix-exception-on-production-environment
branch
from
de1c0dc
to
e4ee616
Compare
bbonislawski
force-pushed
the
fix-exception-on-production-environment
branch
from
e4ee616
to
ea6ff29
Compare
bbonislawski
added a commit
to spark-solutions/spree
that referenced
this pull request
Nov 27, 2017
if asset pipeline tries to fetch asset from url on production, it raises TypeError because of problem with sprockets issue in premailer-rails: fphilipe/premailer-rails#208
bbonislawski
added a commit
to spark-solutions/spree
that referenced
this pull request
Nov 27, 2017
if asset pipeline tries to fetch asset from url on production, it raises TypeError because of problem with sprockets issue in premailer-rails: fphilipe/premailer-rails#208
bbonislawski
added a commit
to spark-solutions/spree
that referenced
this pull request
Nov 27, 2017
if asset pipeline tries to fetch asset from url on production, it raises TypeError because of problem with sprockets issue in premailer-rails: fphilipe/premailer-rails#208
bbonislawski
added a commit
to spark-solutions/spree
that referenced
this pull request
Nov 27, 2017
if asset pipeline tries to fetch asset from url on production, it raises TypeError because of problem with sprockets issue in premailer-rails: fphilipe/premailer-rails#208
|
@bbonislawski thanks for your PR. I think #209, which has been merged, addressed this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running app with production environment it tries to load asset that doesn't exist in pipeline, it raises TypeError.
I ran into it when I had link to external css but AssetPipelineLoader tried to fetch it first and raised TypeError.