Add ability to skip premailer #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is set to 'off' or 'false'.
|
Changes Unknown when pulling 5743fff on tjsingleton:allow_skipping_transform into * on fphilipe:master*. |
|
Thanks, I’ll merge it as soon as I find some time. |
|
Do you think you'll find time to merge this PR in soon? It would be great to selectively disable premailer where it conflicts with other integrations such as sms-fu, or to selectively enable premailer on specific mailers. |
|
Yes, I'll be merging this soon. Sorry for taking months. But right now I finally found some time and motivation to improve the gem. Thanks for the idea! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip transforming message when the header[:premailer] is set to 'off' or 'false'.
The strings ('off' or 'false') were required, because the mail gem converted
message[:premailer] = falseinto a premailer header w\ a nil value.