handle file not being in digest for asset pipeline #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AssetPipelineLoader would use Kernel.open to try and retreive an absolute path on the server (i.e. '/stylesheets/email.css'). This patch makes request_and_unzip return nil when the file cannot be found so that the FileSystemLoader is used as a last resort.
|
Should this also handle the case where |
this happens when digests are off: config.assets.digest == false thanks for the suggestion @jezstephens
|
Digests are no longer used to construct the URL. Instead the original URL is used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AssetPipelineLoader would use Kernel.open to try and retreive an
absolute path on the server (i.e. '/stylesheets/email.css'). This patch
makes request_and_unzip return nil when the file cannot be found so that
the FileSystemLoader is used as a last resort.