Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac client layout using tabs #23

Closed
DerAndereAndi opened this issue Dec 19, 2010 · 13 comments
Closed

Mac client layout using tabs #23

DerAndereAndi opened this issue Dec 19, 2010 · 13 comments
Labels

Comments

@DerAndereAndi
Copy link

I am often restarting my apps and this will always result in a new window popping up and I have to close the old one by also deciding not to save the content (which is my default). Sometimes I have the app running on simulator and the device and want to compare the logs.

So because of this scenario I have the following suggestions:

  • The Mac client should be a single window app, where each log will appear in a new tab
  • Setting to deactivate the dialog asking to save the content if it is not done
  • Option to have the same client appear in the same tab after it starts again instead of opening a new window/tab if the old one is still available
  • Split view (like in Kaleidoscope) of 2 or maybe even more logs. All share the same left sidebar and bottom toolbar
  • In split view align the log entries of all visible logs by a global time stamp column, so it is clear what happens where and when

Great job so far!!!
Andreas

@fpillet
Copy link
Owner

fpillet commented Dec 19, 2010

These are all features I've been considering. Right now the target is to release a 1.0 ASAP and later work on improving the main window. On my list is definitely a way to group all connections from the same app in a single window, I'm still trying to decide which UI is best for this. Regarding the split view "diff" like, it's a very good idea -- but I may not have enough free time to do it soon. Definitely a great idea, though, that would be very useful.

Thanks for your suggestions!

@DerAndereAndi
Copy link
Author

Sounds great to me :)

Thanks.

@fpillet
Copy link
Owner

fpillet commented Jan 9, 2011

Investigated this a bit, thinking about using Chromium Tabs to reuse the same window everytime a new connection comes in from the same application identifier.

@holtwick
Copy link
Contributor

holtwick commented Jan 9, 2011

I think tabs are always a nice choice, e.g. I last saw them implemented in a great way in Kod, maybe there is useful code to implement it: https://github.com/rsms/kod

But if the connections come from the same application and there is only one running instance at a time (e.g. in iPhoneSimulator this is mostly the case) it would be great to get the data listed in the very same window again (after the 'Connection disconnected' marker).

I prefer this solution because I usually use a 'trial-and-error' approach, that means I start the app, then set a filter in NSLogger Desktop, then try to fix the error and start over again. In my case I always have to do the redundant work of setting the filter and going to the new opened window. This also often results in a desktop flooded by 20 and more windows. If I had only one, I could perfectly put it aside my Simulator or other apps windows.

BTW, I use your app every day and it is just great! I can not remember how I did development before having tags and filters :)

@fpillet
Copy link
Owner

fpillet commented Jan 9, 2011

Yes kod is where I took the idea of using Chromium Tabs. I, too, am bothered by the multiple windows as I tend to have the same workflow as you do. My idea is the same as yours, stuff multiple connections from the same app in the same window, use separate windows for separate apps.

Now adding tabs will require some refactoring of the code, I'm a bit short on time in the coming weeks, I'll do it as time allows.

Thanks for the kind comments, much appreciated!

@holtwick
Copy link
Contributor

If you need to prioritize the features I would rather see the unified log window per app than the tabs ;)

@fpillet
Copy link
Owner

fpillet commented Jan 10, 2011

Actually, we need both: a unified per-app window, that shows the connections as tabs. Although many sessions could lead to an insane number of tabs, so maybe rather use a side list or pop-up to show the connections list.

@holtwick
Copy link
Contributor

I would rather like to see the log continued in the same window. If I start the app that I like to debug the first time, a new window pops up and shows the log. If I start the very same app the second time and the old app instance did already disconnect, I would like to see the log continuing in the very same window. This way I can continue my debugging with the same filters etc. It's kind of a 'reuse' of the logging window. Only new apps (maybe identified by the Bundle ID or another unique identifier) should open new windows. This way tabs become obsolete at all I guess.

@fpillet
Copy link
Owner

fpillet commented Jan 10, 2011

Ohh didn't think about this solution! One of the reasons, I guess, is that I tend to have very crowded logs and I want to start clean every time, instead of stuffing everything in the same list.

Hrm will give a thought to that. This could be very easy to add, and I could add per-app settings in the prefs to let user decide whether to clear previous log, reuse same window, pop new window.

Good thinking, thanks!

@holtwick
Copy link
Contributor

I'm happy you like the idea :) I agree, the user should decide if she/he likes a cleanup. I usually don't need the old logs any more and if so I prefer copying the relevant portion into a separate Textmate document, which I currently do by dragging the marked rows from NSLogger to the TextMate window.

@DerAndereAndi
Copy link
Author

Nice ones.

One addition though, the window/tab per app should also be depending on the client IP address! I am testing the same app on two clients at the same time to test network code.

Regarding the sidebar idea, how about having groups in there per app and if you expand an app, you get all the clients listed that you can choose to open. You could even show a number next to each indicating the number of new/unseen log messages.

@fpillet
Copy link
Owner

fpillet commented Aug 28, 2011

Feature implemented (yeah it took quite some time). Windows were already detecting reconnection from the same client app. Now they have the option of keeping multiple run logs, which can be accessed through the App Runs drop down menu in the toolbar, or from the menu bar's View menu.

There's also a new general pref to let you decide whether NSLogger should keep multiple runs (remember to turn this ON). I added this because sometimes (in particular, in my case), logs can be insanely big and you don't want to keep them around. YMMV.

@fpillet fpillet closed this as completed Aug 28, 2011
@holtwick
Copy link
Contributor

Great feature. Works very well and improves the workflow a lot. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants