Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GaussSieve API #248

Closed
malb opened this issue Jun 3, 2017 · 2 comments
Closed

GaussSieve API #248

malb opened this issue Jun 3, 2017 · 2 comments

Comments

@malb
Copy link
Collaborator

malb commented Jun 3, 2017

Hi, I have a couple of issues with the API of GaussSieve

  • I think GaussSieve should use flags not verbose = True to be consistent with the rest of fplll
  • Why do we have public methods to run_Xsieve() when the user has to specify alg=X at object creation? Isn't that invitation to the user to shoot themselves in the foot? I'd suggest to have only one public sieve() method
  • Why do we have a separate public call to set the target norm (I propose to rename goal_norm to target_norm), shouldn't that be a parameter for the sieve() method?
  • It would be good to have a public function to recover more than one vector from the sieve, say an iterator?
shi-bai added a commit that referenced this issue Jun 3, 2017
malb added a commit that referenced this issue Jun 6, 2017
@shi-bai
Copy link
Collaborator

shi-bai commented Jun 6, 2017

Thanks Martin. What does the first one mean? "I think GaussSieve should use flags not verbose = True to be consistent with the rest of fplll"

@malb
Copy link
Collaborator Author

malb commented Jun 6, 2017

LLL, BKZ etc. accept a flags parameter, one of which is LLL_VERBOSE or BKZ_VERBOSE. I suggest to use the same API for sieving, i.e. to turn the verbose parameter into flags and to define SIEVE_VERBOSE

@malb malb closed this as completed Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants