Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Solaris issues #348

Merged
merged 2 commits into from Feb 5, 2018
Merged

Fix Solaris issues #348

merged 2 commits into from Feb 5, 2018

Conversation

jdemeyer
Copy link
Contributor

@jdemeyer jdemeyer commented Feb 5, 2018

This fixes two issues when compiling on Solaris with GCC-5.4.0.

The first is an issue with pow():

nr/dpe.h: In function 'void dpe_pow_si(dpe_struct*, const dpe_struct*, unsigned int)':
nr/dpe.h:718:35: error: call of overloaded 'pow(const double&, const unsigned int&)' is ambiguous
   DPE_MANT(x) = pow(DPE_MANT(y), k);

The second is GCC bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=10200
The existence of a templated norm function causes GCC to misparse if (p->norm < v->norm)

@codecov
Copy link

codecov bot commented Feb 5, 2018

Codecov Report

Merging #348 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #348   +/-   ##
=======================================
  Coverage   73.87%   73.87%           
=======================================
  Files          55       55           
  Lines        4891     4891           
=======================================
  Hits         3613     3613           
  Misses       1278     1278
Impacted Files Coverage Δ
fplll/sieve/sieve_gauss_3sieve.cpp 91.26% <100%> (ø) ⬆️
fplll/sieve/sieve_gauss_4sieve.cpp 87.5% <100%> (ø) ⬆️
fplll/nr/dpe.h 81.87% <100%> (ø) ⬆️
fplll/sieve/sieve_gauss_2sieve.cpp 96.07% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01d54d8...f9ea48c. Read the comment docs.

@malb malb merged commit 696cb14 into fplll:master Feb 5, 2018
@malb
Copy link
Collaborator

malb commented Feb 5, 2018

Thank you!

@malb malb mentioned this pull request May 18, 2018
0-wiz-0 pushed a commit to NetBSD/pkgsrc-wip that referenced this pull request May 18, 2018
This release is a bugfix release. Major changes in fplll-5.2.1 compared to fplll-5.2.0:

- [Possibly resolved the Gram bug](fplll/fplll#349) by Koen de Boer
- [Fix Solaris issues](fplll/fplll#348) by Jeroen Demeyer
- [Unify randomness on 32-bit and 64-bit systems](fplll/fplll#345) by Martin Albrecht
- [Adding Windows 10 instructions to the readme](fplll/fplll#337) by Thijs Laarhoven
- [Can use mpir instead of gmp](fplll/fplll#335) by Laurent Gr?my
- [Dot product](fplll/fplll#326) by Laurent Gr?my
- [make MatGSOGram.row_swap public](fplll/fplll#325) by Martin Albrecht
- [dd wrapper](fplll/fplll#322) by Gilles Villard

We also fixed various other issues, see
fplll/fplll@5.2.0...5.2.1 for details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants