high-level babai method for GSO objects #492
Conversation
| if (!gso) | ||
| { | ||
| from_canonical(x, v, start, dimension); | ||
| MatGSOInterface<ZT, FT>::babai(w, x, start, dimension); |
There was a problem hiding this comment.
Should this be MatGSOInterface here? I'm wondering if you'd ever want to do this rather than explicitly calling MatGSO's babai's directly.
To be clear: this would call MatGSOInterface<ZT, FT>'s babai, which would then virtually dispatch to MatGSO<ZT, FT>'s babai. A smart compiler might even de-virtualise this. So there's no correctness issue here: perhaps just a clearness one.
There was a problem hiding this comment.
I was going with "communicating intent" a la: To do the GSO basis transform, we run it using our basis and then call the generic superclass code on the transformed input. Perhaps those methods shouldn't be virtual though?
There was a problem hiding this comment.
Ah good point. I'm ambivalent on keeping them virtual: whilst we don't need it now, it does communicate intent well.
| } | ||
| else | ||
| { | ||
| MatGSOInterface<ZT, FT>::babai(w, v, start, dimension); |
No description provided.