Drop support for "GMP integer" resources

GMP always returns \GMP objects starting with PHP 5.6.0.
fpoirotte · May 12, 2018 · 75f9262 · 75f9262
1 parent 9147956
commit 75f9262
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/src/NativeEncoder.php b/src/NativeEncoder.php
@@ -302,8 +302,7 @@ public static function convert($value)
             return $value;
         }
 
-        if ($value instanceof \GMP ||
-            (is_resource($value) && get_resource_type($value) === 'GMP integer')) {
+        if ($value instanceof \GMP) {
             $candidates = array(
                 '\\fpoirotte\\XRL\\Types\\I4',
                 '\\fpoirotte\\XRL\\Types\\I8',

diff --git a/src/Types/AbstractInteger.php b/src/Types/AbstractInteger.php
@@ -31,9 +31,7 @@ public function set($value)
     {
         $size = static::INTEGER_BITS;
 
-        // Versions before PHP 5.6 used resources to represent big numbers
-        // while new versions use objects instead.
-        if ((is_resource($value) && get_resource_type($value) === 'GMP integer') || ($value instanceof \GMP)) {
+        if (is_object($value) && $value instanceof \GMP) {
             $value = gmp_strval($value, 10);
         }
 

diff --git a/src/Types/BigInteger.php b/src/Types/BigInteger.php
@@ -43,9 +43,7 @@ public function set($value)
             throw new \RuntimeException("The GMP extension is required for this operation to work");
         }
 
-        // Versions before PHP 5.6 used resources to represent big numbers
-        // while new versions use objects instead.
-        if ((is_resource($value) && get_resource_type($value) === 'GMP integer') || ($value instanceof \GMP)) {
+        if (is_object($value) && $value instanceof \GMP) {
             // It is already a GMP integer.
         } else {
             $value = @gmp_init($value, 10);