Commit
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -468,7 +468,7 @@ Create a copy of the object with the field `field` replaced by `value`. | |
#if macro | ||
static function buildFromAnonymous(matchField, fields, value, pos) { | ||
var found = false; | ||
var e = haxe.macro.Expr.ExprDef.EObjectDecl(fields.map(function(field)#if (haxe_ver >= 4.0) :haxe.macro.Expr.ObjectField #end { | ||
var e = haxe.macro.Expr.ExprDef.EObjectDecl(fields.map(function(field)#if ((haxe_ver >= 4.0) && !macro ) :haxe.macro.Expr.ObjectField #end { | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
fponticelli
Author
Owner
|
||
var fieldName = field.name; | ||
if(fieldName == matchField) { | ||
found = true; | ||
|
Why?
This breaks haxe 4 compatibility (the whole
#if ... #end
does nothing any more since we are already in an#if macro
and you are testing against!macro
).This line would need to be reverted for thx.core to work with haxe 4, does something break (with haxe < 4?) without this change?