Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with namespace prefixes in C++ string types #321

Merged
merged 5 commits into from
Sep 11, 2023
Merged

Fix issue with namespace prefixes in C++ string types #321

merged 5 commits into from
Sep 11, 2023

Conversation

bocchino
Copy link
Collaborator

  • Revise the C++ code gen
  • Update unit tests to add namespaces and cover this case.

Note: Most of the changes in this PR are updates to the C++ unit test output. The Scala code changes are minimal.

Closes #318.

@bocchino bocchino merged commit d85566c into main Sep 11, 2023
10 checks passed
@bocchino bocchino deleted the issue-318-namespace-prefix branch September 11, 2023 17:23
@bocchino bocchino mentioned this pull request Feb 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeStarch LeStarch Awaiting requested review from LeStarch

@jwest115 jwest115 Awaiting requested review from jwest115

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing namespace prefix in C++ function parameter types
1 participant
@bocchino