Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Packages changes #49

Merged
merged 2 commits into from
Jan 18, 2024
Merged

GitHub Packages changes #49

merged 2 commits into from
Jan 18, 2024

Conversation

thomas-bc
Copy link
Member

@thomas-bc thomas-bc commented Jan 17, 2024

2 changes:

  1. Added a label to the image. See https://docs.github.com/en/enterprise-server@3.8/packages/working-with-a-github-packages-registry/working-with-the-container-registry#labelling-container-images. This is to have it show up in the homepage of the repository, under Packages etc... (I believe)
  2. Changed the way CI authenticates to ghcr.io registry, as suggested by https://docs.github.com/en/actions/security-guides/automatic-token-authentication

@thomas-bc thomas-bc changed the title Add label to connect ghcr to repository GitHub Packages changes Jan 18, 2024
@thomas-bc
Copy link
Member Author

thomas-bc commented Jan 18, 2024

I manually canceled the push event so as not to build the same image twice. We may want to restrict the events that actually build the image since it's a fairly large one.
Other than that, things look good! https://github.com/fprime-community/fprime-workspace-image/pkgs/container/fprime-workspace-image

docker pull ghcr.io/fprime-community/fprime-workspace-image:pr-49 looks quite neat

@capsulecorplab
Copy link
Collaborator

Cool! I've been wondering how to get the image to show up under Packages on the repo homepage, glad you figured that out!

@capsulecorplab
Copy link
Collaborator

Just pulled and ran ghcr.io/fprime-community/fprime-workspace-image:pr-49!
Screenshot from 2024-01-17 21-08-34

Copy link
Collaborator

@capsulecorplab capsulecorplab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@capsulecorplab capsulecorplab merged commit 22bfac2 into main Jan 18, 2024
1 of 2 checks passed
@capsulecorplab capsulecorplab deleted the thomas-bc-patch-1 branch January 18, 2024 04:21
@capsulecorplab
Copy link
Collaborator

Also, opened #50 to disable redundant builds

@capsulecorplab capsulecorplab added the DevOps IT operations for developers label Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevOps IT operations for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants