Fixed splash screen #77
Conversation
* adjusted icon and text center point - misalignment was noticeable on large screen devices
There was a problem hiding this comment.
Looks great on my Pixel 3A and a few different emulators I tried, thanks Matthias. A couple of minor issues though:
- Since you mentioned fixing misalignment of splash and overlay screens, now I am seeing it's still there, very slight one but it's there 😄
- we now have ic_splash.png only for xxxhdpi
I have a Sketch file that I used to generate the status screen icons, should probably use that one to generate splash screen images and that could fix both issues. I'll do that tomorrow though 🙂
|
Ok a weird thing happened, I checked out the RTMP branch and suddenly could see the splash screen again instead of the white screen after checking out this branch again. Guess it's some weird caching issue (I did try uninstalling the app, restarting the phone etc.) and it's still present on the emulators I tried, but running the app on a new emulator shows the splash screen 🤷♂️ |
|
There is still a clear jump in alignment between splash screen and the status icon I can see, but now I am not sure if it's still a real thing or just some caching issue? Is there a way to make sure this cache gets cleared? |
This PR adds a splash screen with a fixed aspect ratio for issue #62
To correctly align the splash image with the overlay, the alignment of the overlay icon and text was correctly centered. (The misalignment was noticeable on large screen devices like Pixel C.)
The splash screen was tested with both light and dark theme on screen resolutions for following devices: