Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed splash screen #77

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

fmatt
Copy link
Collaborator

@fmatt fmatt commented May 28, 2021

This PR adds a splash screen with a fixed aspect ratio for issue #62
To correctly align the splash image with the overlay, the alignment of the overlay icon and text was correctly centered. (The misalignment was noticeable on large screen devices like Pixel C.)
The splash screen was tested with both light and dark theme on screen resolutions for following devices:

  • Pixel 2
  • Pixel 3a
  • Nexus 4
  • Pixel 4XL
  • Pixel C
    Screenshot_1622243390
    Screenshot_1622243391

@fmatt fmatt linked an issue May 28, 2021 that may be closed by this pull request
@fichek fichek self-requested a review May 28, 2021 23:45
Copy link
Member

@fichek fichek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great on my Pixel 3A and a few different emulators I tried, thanks Matthias. A couple of minor issues though:

  1. Since you mentioned fixing misalignment of splash and overlay screens, now I am seeing it's still there, very slight one but it's there 😄
  2. we now have ic_splash.png only for xxxhdpi

I have a Sketch file that I used to generate the status screen icons, should probably use that one to generate splash screen images and that could fix both issues. I'll do that tomorrow though 🙂

@fmatt fmatt marked this pull request as draft May 29, 2021 20:10
Copy link
Member

@jlucidar jlucidar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok. can we test this on some tablets maybe before merging ? Thanks @fmatt !

@fmatt
Copy link
Collaborator Author

fmatt commented May 31, 2021

looks ok. can we test this on some tablets maybe before merging ?

Yes, lets have some more tests, @fichek and i had inconclusive results with yesterdays changes (b7ce0c2).
Does anyone notice a white background before the splash screen?

@jlucidar
Copy link
Member

jlucidar commented Jun 1, 2021

looks ok. can we test this on some tablets maybe before merging ?

Yes, lets have some more tests, @fichek and i had inconclusive results with yesterdays changes (b7ce0c2).
Does anyone notice a white background before the splash screen?

Doesn't happen on my phone (oneplus 5t)

@fichek
Copy link
Member

fichek commented Jun 2, 2021

Ok a weird thing happened, I checked out the RTMP branch and suddenly could see the splash screen again instead of the white screen after checking out this branch again. Guess it's some weird caching issue (I did try uninstalling the app, restarting the phone etc.) and it's still present on the emulators I tried, but running the app on a new emulator shows the splash screen 🤷‍♂️

@fichek fichek marked this pull request as ready for review June 2, 2021 15:07
@fichek
Copy link
Member

fichek commented Jun 2, 2021

There is still a clear jump in alignment between splash screen and the status icon I can see, but now I am not sure if it's still a real thing or just some caching issue? Is there a way to make sure this cache gets cleared?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the splash screen
3 participants