Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebase analytics #53

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Firebase analytics #53

wants to merge 4 commits into from

Conversation

shambler123
Copy link
Collaborator

Add firebase , Crashlytics, Performance API and CustomLogger

@shambler123 shambler123 linked an issue May 19, 2021 that may be closed by this pull request
@fichek fichek changed the title Feature/52 Firebase analytics May 19, 2021
],
"api_key": [
{
"current_key": "AIzaSyDRfdW_nEkshiKZnlUiTY7Ww5R3Ne0Fgog"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how this is handled in open-source projects but I'd suggest to not publish the googles-services.json since somebody knowing these keys can spam firebase with arbitrary events...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question ... it is bound to the package. So in the store its not really possible, but I must admit apps not installed from the play store can spam into the account (but why should they do it :-D )

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a quick research it turned out to be okay to put the google-service.json into the public repository since the keys can be extracted easily from the APK itself. But it is possible to restrict the API access to correctly signed APKs only.
Take a look at: https://stackoverflow.com/a/57067722/6843341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add firebase for Analytics
3 participants