Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Page SPA Support #3

Open
atiernan opened this issue May 15, 2021 · 6 comments
Open

Multi Page SPA Support #3

atiernan opened this issue May 15, 2021 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@atiernan
Copy link
Member

What:

live.fpvout.com should be able to handle multiple pages within the Single Page App

Why:

Currently if you try to navigate to https://live.fpvout.com/hello you'll receive a 404 page from GitHub. This should really be routed through the SPA instead, so we choose what to display

Requirements:

  • A way to catch the current 404 and redirect to the SPA, whilst preserving the route the user was on.
@atiernan atiernan added enhancement New feature or request good first issue Good for newcomers labels May 15, 2021
@sweebee
Copy link

sweebee commented May 16, 2021

I cant find anything how to do this with Github Pages. Isn't it easier to host this on Netlify? Then you can add a _redirects file with:

/*    /index.html   200

Then the Vue router will handle the response.

@atiernan
Copy link
Member Author

This seems like an option for catching the 404.

@sahibalejandro
Copy link
Contributor

^ In that case, wouldn't be easier to just create a random room ID and use it as a query parameter? I mean.. that's what the custom 404.html will do anyways.

@atiernan
Copy link
Member Author

atiernan commented Jan 5, 2022

It's not just about room names for WebRTC, the site should be able to handle any route, for example if we wanted to add a settings page it should be able to handle /settings

@sahibalejandro
Copy link
Contributor

You're right! Will work on a POC too. 👍🏼

sahibalejandro added a commit to sahibalejandro/live.fpvout.com that referenced this issue Jan 6, 2022
@jellehak
Copy link

jellehak commented Mar 25, 2023

why not just use the vue hash router. https://live.fpvout.com/#/settings

( the hash router also works best for PWA )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants