Switch to console.error #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in the webpack/webpack-cli#737 `console.log` corrupts the final json file provided by the `--json` option. They fixed this by switching to `console.error` as seen in this pull request: webpack/webpack-cli#744 I believe the same thing should be done here, since I'm having this line in my json file: ``` webpack-fix-style-only-entries: removing js from style only module: javascripts/appStyles-78c8323b9a1489caa5b8.js ```
|
Thanks for that. Printing to console.err seems wrong at first, but I found in https://webpack.js.org/api/plugins/#reporting-progress that it "prints progress messages to stderr by default", so I am accepting this PR. I will open an issue to use ProgressPlugin instead of just printing the output to console. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in the webpack/webpack-cli#737
console.logcorrupts the final json file provided by the--jsonoption.They fixed this by switching to
console.erroras seen in this pull request: webpack/webpack-cli#744I believe the same thing should be done here, since I'm having this line in my json file: