Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to read manufacturer specific codes #80

Closed
LoadingPleaseWait opened this issue Jul 13, 2019 · 1 comment
Closed

Attempting to read manufacturer specific codes #80

LoadingPleaseWait opened this issue Jul 13, 2019 · 1 comment

Comments

@LoadingPleaseWait
Copy link
Contributor

The description for manufacturer related codes will be wrong most of the time. If the descriptions for one manufacturer's codes are used, it will be wrong for cars of other makes. Giving a description that is only correct some of the time is confusing for users. Instead, perhaps the app should say "Manufacturer Specific".

@fr3ts0n
Copy link
Owner

fr3ts0n commented Aug 25, 2019

You are right, I should eliminate the interpretation of all codes > [PCBU]0FFF, which are OEM-specific by definition.

I will add a text hint about the (already existing) feature to long press any DTC to perform online search on it.

fr3ts0n added a commit that referenced this issue Aug 25, 2019
- since they are only valid for one OEM
- add hint "Long press DFC for online search"
@fr3ts0n fr3ts0n closed this as completed Aug 25, 2019
fr3ts0n added a commit that referenced this issue Aug 26, 2019
- OEM codes: P1xxx, P3000..P33FF
- since they are only valid for one OEM
- add hint "Long press DFC for online search"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants