Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HOMING_SINGLE_AXIS_COMMANDS bug #24

Closed
wants to merge 1 commit into from

Conversation

stackola
Copy link

@stackola stackola commented Dec 9, 2018

In motion_control.h, the 4th 5th and 6th axis homing cycles are defined as HOMING_CYCLE_A/B/C, but in system.c they were being referenced as HOMING_CYCLE_1/2/3

This lead to a compile time error when enabling the feature HOMING_SINGLE_AXIS_COMMANDS

In `motion_control.h`, the 4th 5th and 6th axis homing cycles are defined as  `HOMING_CYCLE_A/B/C`, but in `system.c` they were being referenced as `HOMING_CYCLE_1/2/3`

This lead to a compile time error when enabling the feature `HOMING_SINGLE_AXIS_COMMANDS`
@fra589
Copy link
Owner

fra589 commented Dec 11, 2018

hi @stackola,
Thanks for using grbl-Mega-5X and reporting bugs.
By the way, your patch work with simple axis config, but it is not compatible with cloning ant renaming axis new functionality.
So, I will not merge your pull proposal, I will correct this bug with cloning and renaming compatibility ASAP.
Thanks for your report.
@++;
Gauthier.

@fra589 fra589 self-assigned this Dec 11, 2018
@stackola
Copy link
Author

Understood, thanks for the feedback.
Will you let me know when you fixed it so I can see how the correct fix would have looked like?
Thank you

@fra589
Copy link
Owner

fra589 commented Dec 13, 2018

Hi @stackola,
I just pushed a fix for this bug, but I don't have real CNC compatible for testing this...
Can you test and report if it's OK ?
Thanks,
@++;
Gauthier.

@stackola
Copy link
Author

@fra589, my CNC is in pieces right now, needed some redesign / reprinting. I'll let you know as soon as it's back together

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants