Respect environment CFLAGS #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[1] indirectly removed -Wstrict-prototypes by overwriting the
environment CFLAGS with sysconfig.get_config_var("CFLAGS"), which is
passed to the compiler anyway [2].
sysconfig.get_config_var("OPT") is included in
sysconfig.get_config_var("CFLAGS") [3].
Don't pass -O3 if CFLAGS is set because only the last -O option is used
[4]. -DNDEBUG is typically present in sysconfig.get_config_var("CFLAGS").
[1]
426676c ("silenced annoying -Wstrict-prototypes warning", 2015-06-07)
[2]
https://setuptools.pypa.io/en/latest/userguide/ext_modules.html#compiler-and-linker-options
[3]
https://github.com/python/cpython/blob/351842b46a7cb3c3f23b200d532cf29e4557ad4b/Makefile.pre.in#L101
[4]
https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
==========================================
- Coverage 85.93% 85.87% -0.06%
==========================================
Files 55 55
Lines 10392 10392
==========================================
- Hits 8930 8924 -6
- Misses 1462 1468 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dragonmux
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[1] indirectly removed -Wstrict-prototypes by overwriting the environment CFLAGS with sysconfig.get_config_var("CFLAGS"), which is passed to the compiler anyway [2].
sysconfig.get_config_var("OPT") is included in
sysconfig.get_config_var("CFLAGS") [3].
Don't pass -O3 if CFLAGS is set because only the last -O option is used [4]. -DNDEBUG is typically present in sysconfig.get_config_var("CFLAGS").
[1]
426676c ("silenced annoying -Wstrict-prototypes warning", 2015-06-07)
[2]
https://setuptools.pypa.io/en/latest/userguide/ext_modules.html#compiler-and-linker-options
[3]
https://github.com/python/cpython/blob/351842b46a7cb3c3f23b200d532cf29e4557ad4b/Makefile.pre.in#L101
[4]
https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html