Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UserOAuth.project_list and project_list_v2 #1482

Conversation

ychiucco
Copy link
Collaborator

closes #1481

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I merged main into the current branch.

@ychiucco ychiucco linked an issue May 13, 2024 that may be closed by this pull request
Copy link

github-actions bot commented May 13, 2024

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 1.0 0.8 1.25 0.0 0.0
power 1.0 0.8 1.25 0.0 0.0
dataset 1.0 0.8 1.25 0.0 0.0
project 0.9 0.7 1.29 0.0 0.0
job 0.9 0.9 1.00 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 10.2 10.1 1.01 0.7 0.7
power 411.4 385.0 1.07 440.2 440.2
dataset 171.0 155.8 1.10 171.2 171.2
project 52.3 50.6 1.03 58.9 58.9
job 30.0 31.3 0.96 41.7 41.7

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 10.9 6.8 1.60 2.4 2.4
power 143.6 138.6 1.04 693.4 693.4
dataset 145.5 140.9 1.03 989.2 989.2
project 49.2 48.8 1.01 310.0 310.0
job 38.4 38.3 1.00 245.6 245.6

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 6.4 8.1 0.79 0.1 0.1
power 6.7 7.6 0.88 0.1 0.1
dataset 6.7 7.6 0.88 0.1 0.1
project 8.9 9.9 0.90 2.3 2.3
job 6.6 7.7 0.86 0.1 0.1

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 11.0 11.5 0.96 0.8 0.8
power 25.4 28.2 0.90 29.8 29.8
dataset 19.8 19.4 1.02 17.1 17.1
project 22.5 22.5 1.00 21.5 21.5
job 10.9 11.1 0.98 0.9 0.9

POST /api/v2/project/3/dataset/411/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 163.2 155.5 1.05 275.1 275.1

Copy link

github-actions bot commented May 13, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server/app/models
  __init__.py
  security.py
  fractal_server/app/models/v1
  __init__.py
  project.py
  fractal_server/app/models/v2
  project.py
  fractal_server/app/routes/api/v1
  _aux_functions.py
  project.py
  fractal_server/app/runner/executors/slurm
  executor.py
Project Total  

This report was generated by python-coverage-comment-action

@tcompa tcompa merged commit 24f7a89 into main May 14, 2024
18 checks passed
@tcompa tcompa deleted the 1481-remove-project_list-and-project_list_v2-relationships-from-useroauth branch May 14, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove project_list and project_list_v2 relationships from UserOAuth
2 participants