Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve uvicorn/gunicorn logging #1491

Merged
merged 7 commits into from
May 15, 2024
Merged

Improve uvicorn/gunicorn logging #1491

merged 7 commits into from
May 15, 2024

Conversation

tcompa
Copy link
Collaborator

@tcompa tcompa commented May 15, 2024

Close #1492
Close #1494

Checklist before merging

  • I added an appropriate entry to CHANGELOG.md
  • I merged main into the current branch.

@tcompa tcompa requested a review from ychiucco May 15, 2024 07:17
@tcompa tcompa marked this pull request as ready for review May 15, 2024 07:17
Copy link

github-actions bot commented May 15, 2024

Benchmark comparison

GET /api/alive/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 0.9 0.9 1.00 0.0 0.0
power 0.8 0.8 1.00 0.0 0.0
dataset 0.8 0.8 1.00 0.0 0.0
project 0.8 0.8 1.00 0.0 0.0
job 0.8 0.8 1.00 0.0 0.0

GET /api/v2/dataset/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 7.7 7.5 1.03 0.7 0.7
power 388.4 385.3 1.01 440.2 440.2
dataset 160.1 156.0 1.03 171.2 171.2
project 46.5 47.5 0.98 58.9 58.9
job 26.8 27.1 0.99 41.7 41.7

GET /api/v2/job/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 5.3 5.5 0.96 2.4 2.4
power 137.0 137.6 1.00 693.4 693.4
dataset 142.5 141.3 1.01 989.2 989.2
project 44.9 44.2 1.02 310.0 310.0
job 37.5 35.9 1.04 245.6 245.6

GET /api/v2/project/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 5.7 5.7 1.00 0.1 0.1
power 5.4 5.3 1.02 0.1 0.1
dataset 5.6 5.4 1.04 0.1 0.1
project 7.3 7.2 1.01 2.3 2.3
job 8.0 7.1 1.13 0.1 0.1

GET /api/v2/workflow/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
vanilla 9.3 9.0 1.03 0.8 0.8
power 23.1 22.2 1.04 29.8 29.8
dataset 17.7 18.0 0.98 17.1 17.1
project 20.9 19.7 1.06 21.5 21.5
job 9.0 8.4 1.07 0.9 0.9

POST /api/v2/project/3/dataset/415/images/query/

User Time current (ms) Time main (ms) Ratio current/main Size current (Kb) Size main (Kb)
dataset 151.3 149.8 1.01 275.1 275.1

Copy link

github-actions bot commented May 15, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  fractal_server
  main.py 88
  fractal_server/logger
  __init__.py 160, 164
Project Total  

This report was generated by python-coverage-comment-action

@tcompa tcompa changed the title Improve uvicorn logging Improve uvicorn/gunicorn logging May 15, 2024
@tcompa tcompa merged commit b3c1a80 into main May 15, 2024
@tcompa tcompa deleted the uvicorn-logging branch May 15, 2024 08:53
tcompa added a commit that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change format of gunicorn logs Add timestamps to uvicorn access logs
1 participant