Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yokogawa metadata contains channel that wasn't imaged: handle better #586

Open
jluethi opened this issue Oct 23, 2023 · 1 comment
Open
Assignees

Comments

@jluethi
Copy link
Collaborator

jluethi commented Oct 23, 2023

The Liberali's often have setups where the metadata (specifically the .mrf file) contains channels that were then not acquired. The way this comes up is if a user adds more channels in the microscopy software, but then never uses them.
This becomes and issue when that additional channel has different dimensions. For example, the additional channel is brightfield and has a lower resolution. In that case, we get an error like this one:

Image dimensions
Difference dataframe: 
horiz_pixel_dim       0.108333
vert_pixel_dim        0.108333
horiz_pixels       1280.000000
vert_pixels        1080.000000
bit_depth             0.000000
dtype: float64

ValueError: During metadata parsing, a consistency check failed: 
Image dimensions

In practice, there are no consistency issues in the acquired images, only in the channel metadata.

2 areas for improvement:
a) improve the error message
b) handle this more flexibly: Maybe we can pre-filter the channels and only check channels that were imaged / channels provided as allowed channels

@jluethi
Copy link
Collaborator Author

jluethi commented Oct 23, 2023

Here are example metadata files that reproduce this issue. They need to be renamed to .mlf & .mrf to work with the parsing again. I'll need to see if I find time soon to take a closer look

MeasurementData_mlf.txt
MeasurementDetail_Mrf.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant