DatabaseCleaner configuration for TestCase #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the system's original DatabaseCleaner configuration is maintained, options included, except that any `transaction` strategies for any ORMs are replaced with a `deletion` strategy.
|
Yeah that looks quite involved... |
|
Yeah, DatabaseCleaner doesn't make such things easy, but their structures are consistent and easy to reason about, so while the code requires a fair number of lines, it is at least relatively easy to know what it needs to do and to do simply do it. So I'm not overly worried about the maintenance burden. Plus, I see that in that Anyway, suffice it to say, this is much less brittle and scary than the extensions I have for Sidekiq and Noticed. Compared to that code, I feel great about this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The short version is that we store whatever the system DatabaseCleaner configuration is at the start of before_setup in an instance variable and then restore that configuration at the end of after_teardown. In between, we run the configuration thru a pipeline that selectively replaces any transaction strategies with a corresponding deletion strategy, leaving any other configured strategies untouched.