Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show private messages in own "Profile" view #113

Closed
georgeowell opened this issue Jan 29, 2020 · 3 comments
Closed

Don't show private messages in own "Profile" view #113

georgeowell opened this issue Jan 29, 2020 · 3 comments
Labels
enhancement New feature or request

Comments

@georgeowell
Copy link
Collaborator

What's the problem you want to solved?
When I view my own profile, I see a list of my posts that include my private messages. This gives the impression that they are somehow "public" despite the padlock emoji.

Is there a solution you'd like to recommend?
Private messages aren't visible in own profile page and only visible in "inbox" to reinforce public/private understanding.
@christianbundy christianbundy added the enhancement New feature or request label Jan 29, 2020
@christianbundy
Copy link
Member

Word! Should this be the case for other people's profiles too?

@georgeowell
Copy link
Collaborator Author

Well I should hope if everything is working correctly we are not able to see others people's private messages 😆

Yeh I think distinguishing between private and public space should be very distinct. For example, Patchwork has two main tabs Public and Private.

christianbundy added a commit to christianbundy/oasis that referenced this issue Jan 29, 2020
@christianbundy
Hide private messages from author profiles
53c1a1a 
Problem: Showing private posts on profiles is scary and may give people
the impression that these posts are visible.
fraction#113

Solution: Hide private messages when rendering public profiles and
change the method name to be very clear that it only returns public
messages.
@christianbundy christianbundy mentioned this issue Jan 29, 2020
Merged
@christianbundy
Copy link
Member

Resolved in #114!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
2 participants
@christianbundy @georgeowell