Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oasis menu not centre alligned on mobile devices #135

Closed
georgeowell opened this issue Feb 1, 2020 · 1 comment · Fixed by #147
Closed

Oasis menu not centre alligned on mobile devices #135

georgeowell opened this issue Feb 1, 2020 · 1 comment · Fixed by #147
Assignees
@christianbundy
Labels
bug Something isn't working cosmetic Only visual, not behavioral or semantic good first issue Good for newcomers
Milestone
1: Barebones

Comments

@georgeowell
Copy link
Collaborator

What's the problem you want solved?
On various mobile devices that smaller that a tablet, the menu of Oasis is a little bit squished to the left.

Screenshot from 2020-02-01 15-19-07

Screenshot from 2020-02-01 15-20-05

Is there a solution you'd like to recommend?
Align menu items to the centre for a more balanced and intentional look.

p.s. I haven't found any other bugs on mobile yet 😸
@cinnamon-bun
Copy link
Collaborator

This happened in the navbar refresh #130 because at some widths the lower row only had 2 items in it, and I worried it looked strange for them to be justified left and right with a big gap in the middle. I was in a hurry :)

Ok with me to change it back - undo the style.css changes here but keep flex-wrap: wrap. https://github.com/fraction/oasis/pull/130/files#diff-53ffd62cbaefd7a56d8880d61f0df735R396

@christianbundy christianbundy added the bug Something isn't working label Feb 2, 2020
@christianbundy christianbundy self-assigned this Feb 2, 2020
christianbundy added a commit to christianbundy/oasis that referenced this issue Feb 3, 2020
@christianbundy
Fix nav alignment on smaller screens
e28095e 
Problem: The nav is aligned to the left of the screen on mobile, which
feels off-center and unbalanced on mobile. fraction#135

Solution: Center the menu to optimize for space around the links.
@christianbundy christianbundy mentioned this issue Feb 3, 2020
Merged
@christianbundy christianbundy added the cosmetic Only visual, not behavioral or semantic label Feb 3, 2020
@georgeowell georgeowell added the good first issue Good for newcomers label Feb 3, 2020
@cinnamon-bun cinnamon-bun added this to the Barebones SSB client milestone Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christianbundy christianbundy

Labels
bug Something isn't working cosmetic Only visual, not behavioral or semantic good first issue Good for newcomers
Milestone
1: Barebones
Development

Successfully merging a pull request may close this issue.

Fix nav alignment on smaller screens christianbundy/oasis
3 participants
@christianbundy @georgeowell @cinnamon-bun