Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linebreak between nav emoji and page name #150

Closed
christianbundy opened this issue Feb 3, 2020 · 0 comments · Fixed by #168
Closed

Linebreak between nav emoji and page name #150

christianbundy opened this issue Feb 3, 2020 · 0 comments · Fixed by #168
Labels
bug Something isn't working cosmetic Only visual, not behavioral or semantic good first issue Good for newcomers
Milestone
1: Barebones

Comments

@christianbundy
Copy link
Member

What's the problem you want solved? At a very specific width I'm seeing the nav links break into two lines, which I don't think we want.

Screenshot_2020-02-03 Oasis

Is there a solution you'd like to recommend? I think we should separate the emoji and the page name with a non-breaking space (  in HTML, \xa0 in JS).
@christianbundy christianbundy added bug Something isn't working good first issue Good for newcomers cosmetic Only visual, not behavioral or semantic labels Feb 3, 2020
christianbundy added a commit to christianbundy/oasis that referenced this issue Feb 5, 2020
@christianbundy
Fix emoji and breaking space in main nav
602a495 
Problem: The regular space in the sidebar emoji was breaking the line at
a specific viewport width and the emoji were being shown as the wrong
font.

Solution: Use a non-breaking space and `font-family: initial` for
full-color emoji instead of using the system font.

Resolves fraction#150
Resolves fraction#153
@christianbundy christianbundy mentioned this issue Feb 5, 2020
Merged
@cinnamon-bun cinnamon-bun added this to the Barebones SSB client milestone Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working cosmetic Only visual, not behavioral or semantic good first issue Good for newcomers
Milestone
1: Barebones
Development

Successfully merging a pull request may close this issue.

Fix emoji and breaking space in main nav christianbundy/oasis
2 participants
@christianbundy @cinnamon-bun