Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Own public threads not visible in "Latest" #177

Closed
georgeowell opened this issue Feb 7, 2020 · 0 comments · Fixed by #182
Closed

Own public threads not visible in "Latest" #177

georgeowell opened this issue Feb 7, 2020 · 0 comments · Fixed by #182
Labels
enhancement New feature or request
Milestone
1: Barebones

Comments

@georgeowell
Copy link
Collaborator

georgeowell commented Feb 7, 2020 •
edited

What's the problem you want solved?
It feels weird to not see stuff you just posted in the chronological "Latest" feed.

Is there a solution you'd like to recommend?
Own publish threads should be visible in "Latest". We will need update the feed description also.

Relates to #176. Probably not need if latest mock ups in #170 is implemented.
@georgeowell georgeowell added the enhancement New feature or request label Feb 7, 2020
@georgeowell georgeowell changed the title Own threads not visible in "Latest" Own public threads not visible in "Latest" Feb 7, 2020
@christianbundy christianbundy mentioned this issue Feb 7, 2020
Closed
christianbundy added a commit to christianbundy/oasis that referenced this issue Feb 8, 2020
@christianbundy
Fix and document socialFilter()
8035386 
Problem: The `socialFilter()` function wasn't documented and contained a
bug where it wouldn't show your posts when `following = true`. This is
because you usually don't follow yourself, so `following = true` was
basically equivalent to `me = false`.

Solution: Add some documentation and resolve the bug by adding special
handling for when the message is from us *before* passing to the general
implementation for follow/block checking.

Resolves fraction#155
Resolves fraction#177
@christianbundy christianbundy mentioned this issue Feb 8, 2020
Merged
@cinnamon-bun cinnamon-bun added this to the Barebones SSB client milestone Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
1: Barebones
Development

Successfully merging a pull request may close this issue.

Fix and document socialFilter() christianbundy/oasis
2 participants
@georgeowell @cinnamon-bun