Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown link not working for %70 message #242

Closed
christianbundy opened this issue Feb 19, 2020 · 2 comments · Fixed by #356
Closed

Markdown link not working for %70 message #242

christianbundy opened this issue Feb 19, 2020 · 2 comments · Fixed by #356
Labels
bug Something isn't working
Milestone
1: Barebones

Comments

@christianbundy
Copy link
Member

What's the problem you want solved? For some reason the Markdown renderer is taking %70B9TI2hP5QMU59Lx9ozRD5Uh/E7tq4o1Ox8TP07XIg=.sha256 and pointing you to http://localhost:3000/thread/%70B9TI2hP5QMU59Lx9ozRD5Uh/E7tq4o1Ox8TP07XIg=.sha256. That's wrong, and it should be URI encoded as http://localhost:3000/thread/%2570B9TI2hP5QMU59Lx9ozRD5Uh%2FE7tq4o1Ox8TP07XIg%3D.sha256 instead.

Is there a solution you'd like to recommend? Nope, not sure why this is broken yet.
@christianbundy christianbundy added the bug Something isn't working label Feb 19, 2020
@cinnamon-bun cinnamon-bun added this to the Barebones SSB client milestone Feb 20, 2020
@christianbundy christianbundy mentioned this issue Feb 28, 2020
Closed
@georgeowell
Copy link
Collaborator

Is this still the case since e7c38e3

@christianbundy
Copy link
Member Author

I believe so, the problem is upstream in SSB-Markdown, reported as ssbc/ssb-markdown#55

christianbundy added a commit to christianbundy/oasis that referenced this issue Mar 25, 2020
@christianbundy
Fix Markdown link bug
57558e5 
Problem: Some sigil links were broken because of a bug in SSB-Markdown
that was recently resolved.

Solution: Upgrade SSB-Markdown.

Fixes: fraction#242
christianbundy added a commit to christianbundy/oasis that referenced this issue Mar 25, 2020
@christianbundy
Fix Markdown link bug
c4aaf47 
Problem: Some sigil links were broken because of a bug in SSB-Markdown
that was recently resolved.

Solution: Upgrade SSB-Markdown.

Fixes: fraction#242
@christianbundy christianbundy mentioned this issue Mar 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
1: Barebones
Development

Successfully merging a pull request may close this issue.

Fix Markdown link bug christianbundy/oasis
3 participants
@christianbundy @georgeowell @cinnamon-bun