Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialization parameters not used in grid search #108

Open
iamjli opened this issue Feb 23, 2021 · 0 comments
Open

Initialization parameters not used in grid search #108

iamjli opened this issue Feb 23, 2021 · 0 comments

Comments

@iamjli
Copy link
Contributor

iamjli commented Feb 23, 2021

self.grid_randomization calls self._eval_PCSF_runs

results = pool.map(self._eval_PCSF_runs, param_sets)

But this resets all parameters to default parameters. So there isn't a way to run grid randomization with a non-default edge noise for instance.

This could be fixed in this line:

param_sets = [{'w': w, 'b': b, 'g': g, 'noisy_edge_reps': noisy_edges_reps, 'random_terminals_reps': random_terminals_reps} for (w, b, g) in product(Ws, Bs, Gs)]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant