security/acme-client: remove dead code, refs opnsense#3790

fraenki · Feb 7, 2024 · 84644d4 · 84644d4
1 parent 91633cc
commit 84644d4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/security/acme-client/pkg-descr b/security/acme-client/pkg-descr
@@ -8,6 +8,9 @@ WWW: https://github.com/acmesh-official/acme.sh
 Plugin Changelog
 ================
 
+Fixed:
+* proc_open(): Argument #2 ($descriptor_spec) must be of type array
+
 4.0
 
 NOTE: This is a new major release with backwards-incompatible changes.

diff --git a/security/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeAutomation/Base.php b/security/acme-client/src/opnsense/mvc/app/library/OPNsense/AcmeClient/LeAutomation/Base.php
@@ -129,10 +129,9 @@ public function runAcme()
           . ' '
           . '--deploy '
           . implode(' ', $this->acme_args);
-        LeUtils::log_debug('running acme.sh command: ' . (string)$acmecmd, $this->debug);
-        $proc = proc_open($acmecmd, $proc_desc, $proc_pipes, null, $proc_env);
 
         // Run acme.sh command
+        LeUtils::log_debug('running acme.sh command: ' . (string)$acmecmd, $this->debug);
         $result = LeUtils::run_shell_command($acmecmd, $proc_env);
 
         // acme.sh records the last used deploy hook and would automatically