galera::status must be conditionally included #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fraenki
requested changes
Dec 19, 2019
|
@efoft Sorry for not being clear on this. We should keep and use all three class parameters as OPTIONALs, this includes |
|
definately, no problem! :) |
|
@efoft Merged, thanks! |
fraenki
added a commit
that referenced
this pull request
Feb 10, 2020
We need to first evaluate $status_check, otherwise it would never be used. Using the root account is only a fallback. While here, remove the obsolete parameters; it's a breaking change, but we're not going to include this in a bugfix release anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now galera::status in just included unconditionally in galera::validation so setting status_check to false doesn't prevent installing clustercheck script and xinetd service in case validation = true. I suggest to use for validation either status user/password if they are given and status_check enabled or to use root account as failback