Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-6: mysql type of database is still generating with pg types #11

Merged
merged 2 commits into from
Mar 30, 2019

Conversation

fraenky8
Copy link
Owner

This PR fix #6 and does the following:

  • Adds two new functions to the database interface
    • return the NullTime data type for a column of a sepcific database and its driver
    • return the specific driver for the database to generate a correct import statement
  • Removes the unneccessary import of database/sql when there is not column of null type

Added therefore two new function to the database interface to return
the database specific driver and temporal data type.
It was added when a column of null-type was detected regardless if it
is a time value or not. If the table has no null values beside the time
null value then the import is not used and can be removed safely.

Added new function to wrap the generation of import statements and used a
new struct to hold some information about a column when it gets processed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mysql type of database is still generating with pg types
1 participant