ISSUE-12: Id should be all caps #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function replaces common strings to their upper-case representation for a idiomatic go behaviour. See https://github.com/golang/go/wiki/CodeReviewComments#initialisms Added also a unit test.
|
I noticed it incorrectly capitalised mIDllename in my struct https://youtu.be/1mnMmMF3Dx0?t=862 😅 |
|
Yes this is the downside of the implementation I did - because to follow idiomatic go I can't distinguish where the ID (or any other string) should be. If I only focus on start and beginning, this would make life easier of course - but not sure if it's then suitable for all. You can disable this behaviour by passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #12 and does the following: