ISSUE-10: Add unit tests #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use DI to make use of best practices and to enable unit testing.
Inject a writer into the Run() function.
So the imports are sorted in correct order.
Therefore the constructor does not two things. The Connect() has to be called explicit now.
The unit test checks for every database its supported string/text column data types if the output produced by the Run() function is correct.
The unit test checks for every database its supported integer column data types if the output produced by the Run() function is correct.
The unit test checks for every database its supported float column data types if the output produced by the Run() function is correct.
The unit test checks for every database its supported temporal column data types if the output produced by the Run() function is correct. While writing these tests a bug came up which made it impossible to use a primitive/builtin time.Time and a database specific time column type at the same time. Fixed that with collecting information about the columns in the columnInfo struct.
The unit test checks for every database its supported bool column data types if the output produced by the Run() function is correct.
Put the tagger implementation into its own package. Removed the experimental SQL-tag.
Also refactored and rearranged the code.
Also renamed constructor function to New()
This increases also the test coverage.
Added a case where given string is empty. Fixed typo in toInitialisms test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #10 and does the following:
Run()function for every supprted database and its datatypes:Run()function)[ ] sql