Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new flag to allow skipping errors in tables #20

Merged
merged 6 commits into from
Jul 17, 2019

Conversation

ronniegane
Copy link
Contributor

Resolves #19
Added a new flag, -f, which will simply print errors for tables it can't turn into structs rather than stopping. This way all tables that can be correctly processed will be.

@ronniegane ronniegane changed the title 19 skip errors new flag to allow skipping errors in tables Jun 27, 2019
Copy link
Owner

@fraenky8 fraenky8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Only a minor change to error formatting.

Oh and can you please also update the README and the godoc (doc.go) to reflect the new command line parameter? 👍

internal/cli/tables-to-go-cli.go Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@fraenky8 fraenky8 merged commit c210705 into fraenky8:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to continue through errors
2 participants